-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: drop LoggerStages #5673
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will conflict with the predict PR, if this is merged first. Would you rather put here all non-predict changes from #5579? |
yes, I have noticed it too, that is why I paused this action till "predict" PR is merged... |
c63c85b
to
2f62063
Compare
2f62063
to
1042845
Compare
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5673 +/- ##
================================================
- Coverage 89% 84% -5%
================================================
Files 168 168
Lines 12423 12412 -11
================================================
- Hits 11103 10461 -642
- Misses 1320 1951 +631 |
akihironitta
approved these changes
Jan 30, 2021
tchaton
approved these changes
Jan 30, 2021
rohitgr7
approved these changes
Jan 30, 2021
awaelchli
approved these changes
Jan 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resolves #5659
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃