Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: drop LoggerStages #5673

Merged
merged 2 commits into from
Jan 30, 2021
Merged

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 27, 2021

What does this PR do?

Resolves #5659

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the refactor label Jan 27, 2021
@Borda Borda added this to the 1.2 milestone Jan 27, 2021
@Borda Borda requested a review from carmocca January 27, 2021 07:53
@Borda Borda linked an issue Jan 27, 2021 that may be closed by this pull request
@carmocca
Copy link
Contributor

This will conflict with the predict PR, if this is merged first.

Would you rather put here all non-predict changes from #5579?

@Borda
Copy link
Member Author

Borda commented Jan 27, 2021

This will conflict with the predict PR, if this is merged first.

yes, I have noticed it too, that is why I paused this action till "predict" PR is merged...

@Borda Borda changed the title Refactor: drop LoggerStages [blocked by #5579] Refactor: drop LoggerStages Jan 27, 2021
@Borda Borda changed the title [blocked by #5579] Refactor: drop LoggerStages Refactor: drop LoggerStages Jan 29, 2021
@Borda Borda force-pushed the refactor/drop-loggerstages branch from c63c85b to 2f62063 Compare January 29, 2021 16:47
@Borda Borda force-pushed the refactor/drop-loggerstages branch from 2f62063 to 1042845 Compare January 29, 2021 22:56
@Borda Borda marked this pull request as ready for review January 29, 2021 22:56
@mergify mergify bot removed the has conflicts label Jan 29, 2021
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #5673 (08f13d9) into release/1.2-dev (a17c941) will decrease coverage by 5%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##           release/1.2-dev   #5673    +/-   ##
================================================
- Coverage               89%     84%    -5%     
================================================
  Files                  168     168            
  Lines                12423   12412    -11     
================================================
- Hits                 11103   10461   -642     
- Misses                1320    1951   +631     

@Borda Borda enabled auto-merge (squash) January 30, 2021 00:00
@Borda Borda self-assigned this Jan 30, 2021
@Borda Borda added the ready PRs ready to be merged label Jan 30, 2021
@Borda Borda merged commit fca9272 into release/1.2-dev Jan 30, 2021
@Borda Borda deleted the refactor/drop-loggerstages branch January 30, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate LoggerStages Enum
6 participants