-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Add StochasticWeightAveraging (SWA) callback #5640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
reviewed
Jan 25, 2021
Hello @tchaton! Thanks for updating this PR.
Comment last updated at 2021-02-10 23:45:21 UTC |
tchaton
requested review from
awaelchli,
Borda,
edenlightning,
justusschock,
SeanNaren and
williamFalcon
as code owners
January 25, 2021 15:18
SeanNaren
reviewed
Jan 25, 2021
justusschock
approved these changes
Jan 25, 2021
SkafteNicki
approved these changes
Jan 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :]
teddykoker
approved these changes
Feb 5, 2021
Borda
reviewed
Feb 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add typing?
SeanNaren
approved these changes
Feb 9, 2021
carmocca
reviewed
Feb 10, 2021
edenlightning
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds SWA Callback to Lightning.
https://pytorch.org/blog/pytorch-1.6-now-includes-stochastic-weight-averaging/
Fixes #1894
TODO:
Docs issue: https://github.com/PyTorchLightning/pytorch-lightning/pull/5640/checks?check_run_id=1839752310edit: not related to SWA but CI.Before submitting
PR review