-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More EpochResultStore refactors! 🎉 #5522
Conversation
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5522 +/- ##
================================================
+ Coverage 83% 88% +5%
================================================
Files 181 181
Lines 12929 12742 -187
================================================
+ Hits 10771 11236 +465
+ Misses 2158 1506 -652 |
pytorch_lightning/trainer/connectors/logger_connector/epoch_result_store.py
Show resolved
Hide resolved
pytorch_lightning/trainer/connectors/logger_connector/epoch_result_store.py
Show resolved
Hide resolved
pytorch_lightning/trainer/connectors/logger_connector/epoch_result_store.py
Outdated
Show resolved
Hide resolved
…sult_store.py Co-authored-by: Jirka Borovec <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great refactor ! Let refactor info a proper structure as recommended by @ananthsub.
pytorch_lightning/trainer/connectors/logger_connector/epoch_result_store.py
Outdated
Show resolved
Hide resolved
@carmocca mind check the conflicts so we can start review :] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
What does this PR do?
Refactoring done while debugging #5521
Before submitting
PR review