Add missing val/test hooks in LightningModule #5467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitgr7
requested review from
awaelchli,
Borda,
justusschock,
SeanNaren,
tchaton and
williamFalcon
as code owners
rohitgr7
commented
Jan 12, 2021
| 'on_validation_model_train', | ||
| 'on_epoch_end', | ||
| 'on_train_epoch_end', | ||
| 'on_train_end', | ||
| 'on_fit_end', | ||
| 'teardown', | ||
| ] | ||
|
|
||
| assert model.called == expected |
There was a problem hiding this comment.
shall this be updated the way it's done with callback using mock?
There was a problem hiding this comment.
that would be great (in a follow up pr). let me know if you need help
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5467 +/- ##
===============================================
- Coverage 93% 93% -0%
===============================================
Files 151 151
Lines 10641 10645 +4
===============================================
- Hits 9860 9858 -2
- Misses 781 787 +6 |
carmocca
approved these changes
Jan 12, 2021
williamFalcon
approved these changes
Jan 12, 2021
s-rog
approved these changes
Jan 13, 2021
Borda
pushed a commit
that referenced
this pull request
Jan 13, 2021
* add missing val/test hooks * chlog * None Co-authored-by: Roger Shieh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #5442
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃