-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set minimal req. PT 1.4 #5418
Merged
Merged
set minimal req. PT 1.4 #5418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
requested review from
awaelchli,
edenlightning,
justusschock,
SeanNaren,
tchaton and
williamFalcon
as code owners
January 8, 2021 14:24
justusschock
approved these changes
Jan 8, 2021
some strange error, but unreleted:
|
ydcjeff
approved these changes
Jan 8, 2021
carmocca
approved these changes
Jan 8, 2021
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5418 +/- ##
===============================================
Coverage 93% 93%
===============================================
Files 151 151
Lines 10617 10617
===============================================
+ Hits 9829 9835 +6
+ Misses 788 782 -6 |
awaelchli
approved these changes
Jan 8, 2021
tchaton
approved these changes
Jan 10, 2021
SkafteNicki
approved these changes
Jan 10, 2021
edenlightning
approved these changes
Jan 11, 2021
williamFalcon
approved these changes
Jan 12, 2021
Borda
added a commit
that referenced
this pull request
Jan 13, 2021
* set minimal req. PT 1.4 * chlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
ci
Continuous Integration
priority: 1
Medium priority task
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
for lack of older PT version on Conda we drop 1.3 from testing
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃