Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set minimal req. PT 1.4 #5418

Merged
merged 8 commits into from
Jan 13, 2021
Merged

set minimal req. PT 1.4 #5418

merged 8 commits into from
Jan 13, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 8, 2021

What does this PR do?

for lack of older PT version on Conda we drop 1.3 from testing

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added bug Something isn't working ci Continuous Integration Important labels Jan 8, 2021
@Borda Borda added this to the 1.2 milestone Jan 8, 2021
@Borda Borda added the priority: 1 Medium priority task label Jan 8, 2021
.github/workflows/nightly.yml Show resolved Hide resolved
@Borda Borda added the ready PRs ready to be merged label Jan 8, 2021
@Borda Borda enabled auto-merge (squash) January 8, 2021 14:39
@Borda Borda disabled auto-merge January 8, 2021 14:40
@Borda
Copy link
Member Author

Borda commented Jan 8, 2021

some strange error, but unreleted:

platform linux -- Python 3.6.12, pytest-5.0.0, py-1.10.0, pluggy-0.13.1 -- /opt/hostedtoolcache/Python/3.6.12/x64/bin/python
cachedir: .pytest_cache
rootdir: /home/runner/work/pytorch-lightning/pytorch-lightning, inifile: setup.cfg
plugins: hydra-core-1.0.0
Fatal Python error: Segmentation fault

@Borda Borda self-assigned this Jan 8, 2021
@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #5418 (26eb369) into release/1.2-dev (51b9df3) will increase coverage by 0%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           release/1.2-dev   #5418   +/-   ##
===============================================
  Coverage               93%     93%           
===============================================
  Files                  151     151           
  Lines                10617   10617           
===============================================
+ Hits                  9829    9835    +6     
+ Misses                 788     782    -6     

@Borda Borda enabled auto-merge (squash) January 10, 2021 17:53
@Borda Borda merged commit 7e4d6cb into release/1.2-dev Jan 13, 2021
@Borda Borda deleted the req/pt-1.4 branch January 13, 2021 00:15
Borda added a commit that referenced this pull request Jan 13, 2021
* set minimal req. PT 1.4

* chlog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Continuous Integration priority: 1 Medium priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants