Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add possibility for nested loaders #5404

Merged
merged 7 commits into from
Jan 24, 2021
Merged

Conversation

justusschock
Copy link
Member

@justusschock justusschock commented Jan 7, 2021

What does this PR do?

Extends #1959 to the possibility of nested loaders as mentioned by @tchaton in #1959 (comment)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

Ps: Sorry for the formatting, this happens automatically on import in my IDE. Hope this isn't an issue in this small PR.

@justusschock justusschock added this to the 1.2 milestone Jan 7, 2021
@justusschock justusschock self-assigned this Jan 7, 2021
@pep8speaks
Copy link

pep8speaks commented Jan 7, 2021

Hello @justusschock! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-01-24 10:45:49 UTC

@justusschock justusschock enabled auto-merge (squash) January 7, 2021 13:38
@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #5404 (baee078) into release/1.2-dev (6386f45) will decrease coverage by 0%.
The diff coverage is 94%.

@@               Coverage Diff               @@
##           release/1.2-dev   #5404   +/-   ##
===============================================
- Coverage               92%     92%   -0%     
===============================================
  Files                  153     153           
  Lines                10834   10840    +6     
===============================================
  Hits                 10011   10011           
- Misses                 823     829    +6     

@Borda Borda added data handling Generic data-related topic feature Is an improvement or enhancement labels Jan 8, 2021
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Borda Borda added the ready PRs ready to be merged label Jan 8, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great !

@mergify mergify bot removed the has conflicts label Jan 22, 2021
@justusschock justusschock merged commit ef7345d into release/1.2-dev Jan 24, 2021
@justusschock justusschock deleted the nested_loaders branch January 24, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data handling Generic data-related topic feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants