-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add possibility for nested loaders #5404
Conversation
Hello @justusschock! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-01-24 10:45:49 UTC |
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5404 +/- ##
===============================================
- Coverage 92% 92% -0%
===============================================
Files 153 153
Lines 10834 10840 +6
===============================================
Hits 10011 10011
- Misses 823 829 +6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great !
What does this PR do?
Extends #1959 to the possibility of nested loaders as mentioned by @tchaton in #1959 (comment)
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
Ps: Sorry for the formatting, this happens automatically on import in my IDE. Hope this isn't an issue in this small PR.