Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequential model parallel with multi nodes regarding --num_nodes #5327

Merged
merged 3 commits into from
Jan 2, 2021

Conversation

haven-jeon
Copy link
Contributor

@haven-jeon haven-jeon commented Jan 2, 2021

What does this PR do?

Fixes #5312

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes [if needed]?
  • Did you write any new necessary tests [no need for typos, docs]?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone are aligned!

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jan 2, 2021

Codecov Report

Merging #5327 (33ffcbb) into master (ab7512d) will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #5327   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         134     134           
  Lines        9950    9950           
======================================
  Hits         9261    9261           
  Misses        689     689           

@Borda Borda added the bug Something isn't working label Jan 2, 2021
@Borda Borda added this to the 1.1.x milestone Jan 2, 2021
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be great to have a test for it too

@tchaton tchaton merged commit d20fd8e into Lightning-AI:master Jan 2, 2021
Borda pushed a commit that referenced this pull request Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sequential model parallel with multi nodes regarding --num_nodes
4 participants