Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop deprecated TrainResult #5323

Merged
merged 8 commits into from
Jan 4, 2021
Merged

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 1, 2021

What does this PR do?

removing deprecated class TrainResult, this shall be already removed in 1.0

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes [if needed]?
  • Did you write any new necessary tests [no need for typos, docs]?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone are aligned!

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the refactor label Jan 1, 2021
@Borda Borda added this to the 1.2 milestone Jan 1, 2021
@Borda Borda force-pushed the deprecated/drop-train-result branch from 9dd70b9 to 76a5762 Compare January 1, 2021 23:38
@Borda Borda marked this pull request as ready for review January 2, 2021 00:07
@Borda Borda enabled auto-merge (squash) January 2, 2021 00:16
@Borda Borda disabled auto-merge January 2, 2021 09:44
@Borda Borda self-assigned this Jan 2, 2021
@Borda Borda enabled auto-merge (squash) January 2, 2021 10:58
Copy link
Contributor

@gianscarpe gianscarpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I did the same in test_cpu in my PR #4820

@Borda
Copy link
Member Author

Borda commented Jan 2, 2021

lgtm, I did the same in test_cpu in my PR #4820

nice, but yours is doing even more things, this is just removal, so no worries, we can lads both 🐰
btw, I see that yours is a destination for the master...

@Borda Borda added the ready PRs ready to be merged label Jan 2, 2021
@Borda Borda force-pushed the deprecated/drop-train-result branch from 635cf85 to e3aa6cb Compare January 3, 2021 13:41
@Borda Borda force-pushed the deprecated/drop-train-result branch from e3aa6cb to 322b0e4 Compare January 3, 2021 14:42
@Borda Borda requested a review from carmocca January 3, 2021 16:35
@Borda Borda merged commit af833f6 into release/1.2-dev Jan 4, 2021
@Borda Borda deleted the deprecated/drop-train-result branch January 4, 2021 01:54
@Borda
Copy link
Member Author

Borda commented Jan 4, 2021

needed for #5005

@Borda Borda mentioned this pull request Jan 26, 2021
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants