-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable checkpointing, earlystopping and logging with fast_dev_run #5277
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5277 +/- ##
=======================================
- Coverage 93% 92% -1%
=======================================
Files 134 134
Lines 9956 10152 +196
=======================================
+ Hits 9267 9305 +38
- Misses 689 847 +158 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! we just need to figure out a few details regarding callbacks and logger :)
Hello @rohitgr7! Thanks for updating this PR.
Comment last updated at 2021-01-05 02:37:32 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work ! Can you clarify why you removed trainer.logger ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@rohitgr7 mind check isort formating? |
just thinking if the disable checkpointing on fast_dev_run is rather a API change so it shall be 1.2? |
…5277) * Disable checkpointing, earlystopping and logger with fast_dev_run * docs * chlog * disable callbacks and enable DummyLogger * add log * use dummy logger method * Apply suggestions from code review Co-authored-by: Adrian Wälchli <[email protected]> Co-authored-by: chaton <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> (cherry picked from commit f740245)
What does this PR do?
Fixes #5136 + disable checkpointing and logging when using
fast_dev_run
.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃