Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable checkpointing, earlystopping and logging with fast_dev_run #5277

Merged
merged 12 commits into from
Jan 5, 2021
Merged

Disable checkpointing, earlystopping and logging with fast_dev_run #5277

merged 12 commits into from
Jan 5, 2021

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Dec 27, 2020 •
edited
Loading

What does this PR do?

Fixes #5136 + disable checkpointing and logging when using fast_dev_run.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes [if needed]?
  • Did you write any new necessary tests [no need for typos, docs]?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone are aligned!

Did you have fun?

Make sure you had fun coding 🙃

@rohitgr7 rohitgr7 added the bug Something isn't working label Dec 27, 2020
@rohitgr7 rohitgr7 added this to the 1.1.x milestone Dec 27, 2020
@codecov
Copy link

codecov bot commented Dec 27, 2020 •
edited
Loading

Codecov Report

Merging #5277 (51635cb) into master (b0051e8) will decrease coverage by 1%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #5277    +/-   ##
=======================================
- Coverage      93%     92%    -1%     
=======================================
  Files         134     134            
  Lines        9956   10152   +196     
=======================================
+ Hits         9267    9305    +38     
- Misses        689     847   +158

@rohitgr7 rohitgr7 changed the title Disable checkpointing, earlystopping and logger with fast_dev_run Disable checkpointing, earlystopping and logging with fast_dev_run Dec 27, 2020
@rohitgr7 rohitgr7 marked this pull request as ready for review December 28, 2020 06:55
awaelchli
awaelchli reviewed Dec 28, 2020
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! we just need to figure out a few details regarding callbacks and logger :)

@pep8speaks
Copy link

pep8speaks commented Dec 28, 2020 •
edited
Loading

Hello @rohitgr7! Thanks for updating this PR.

Line 192:13: W503 line break before binary operator

Line 228:13: W503 line break before binary operator

Comment last updated at 2021-01-05 02:37:32 UTC

@rohitgr7 rohitgr7 requested a review from awaelchli December 28, 2020 20:38
@rohitgr7 rohitgr7 requested a review from Borda January 1, 2021 13:44
@rohitgr7 rohitgr7 requested a review from awaelchli January 3, 2021 17:14
awaelchli
awaelchli approved these changes Jan 3, 2021
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

tchaton
tchaton approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work ! Can you clarify why you removed trainer.logger ?

@rohitgr7 rohitgr7 requested review from carmocca and s-rog January 4, 2021 19:26
@Borda Borda added the ready PRs ready to be merged label Jan 4, 2021
Borda
Borda reviewed Jan 4, 2021
View reviewed changes
Borda
Borda approved these changes Jan 4, 2021
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Borda
Copy link
Member

Borda commented Jan 4, 2021

@rohitgr7 mind check isort formating?

@Borda Borda enabled auto-merge (squash) January 4, 2021 19:45
@Borda Borda added the design Includes a design discussion label Jan 4, 2021
@Borda
Copy link
Member

Borda commented Jan 4, 2021

just thinking if the disable checkpointing on fast_dev_run is rather a API change so it shall be 1.2?
cc: @tchaton @awaelchli

@Borda Borda merged commit f740245 into master Jan 5, 2021
@Borda Borda deleted the bugfix/fdr_disable_ckpt_logs branch January 5, 2021 02:54
Borda pushed a commit that referenced this pull request Jan 6, 2021
@rohitgr7 @Borda
Disable checkpointing, earlystopping and logging with fast_dev_run (#…
9cfbf8d 
…5277)

* Disable checkpointing, earlystopping and logger with fast_dev_run

* docs

* chlog

* disable callbacks and enable DummyLogger

* add log

* use dummy logger method

* Apply suggestions from code review

Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: chaton <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>

(cherry picked from commit f740245)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@carmocca carmocca carmocca approved these changes

@tchaton tchaton tchaton approved these changes

@s-rog s-rog s-rog approved these changes

@edenlightning edenlightning Awaiting requested review from edenlightning

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees
No one assigned
Labels
bug Something isn't working design Includes a design discussion ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.1.x
Development

Successfully merging this pull request may close these issues.

fast_dev_run should set max_steps
7 participants
@rohitgr7 @pep8speaks @Borda @awaelchli @carmocca @tchaton @s-rog