-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolve cyclic import issues in utilities #5256
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @Borda! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-12-24 22:01:09 UTC |
Borda
requested review from
awaelchli,
justusschock,
SeanNaren,
tchaton and
williamFalcon
as code owners
December 23, 2020 23:42
Borda
force-pushed
the
refactor/avail-imports
branch
from
December 24, 2020 22:01
dfa3e0e
to
fe9415f
Compare
Codecov Report
@@ Coverage Diff @@
## release/1.2-dev #5256 +/- ##
===============================================
Coverage 93% 93%
===============================================
Files 140 142 +2
Lines 10010 10014 +4
===============================================
+ Hits 9297 9301 +4
Misses 713 713 |
s-rog
approved these changes
Dec 29, 2020
rohitgr7
approved these changes
Dec 29, 2020
carmocca
approved these changes
Dec 29, 2020
Borda
changed the title
clean avail. imports & enums
Resolving some cyclic import issues
Dec 29, 2020
awaelchli
changed the title
Resolving some cyclic import issues
resolve cyclic import issues in utilities
Dec 29, 2020
awaelchli
approved these changes
Dec 29, 2020
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resolving some cyclic import issues
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃