-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automatic optimization property setter to lightning module #5169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks better to me. Mind update other tests too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it already was like this 😄
will do! |
Codecov Report
@@ Coverage Diff @@
## master #5169 +/- ##
======================================
Coverage 93% 93%
======================================
Files 135 135
Lines 10011 10015 +4
======================================
+ Hits 9324 9328 +4
Misses 687 687 |
* add automatic optimization property setter to lightning module * Update test_manual_optimization.py Co-authored-by: chaton <[email protected]> (cherry picked from commit 8748293)
* add automatic optimization property setter to lightning module * Update test_manual_optimization.py Co-authored-by: chaton <[email protected]> (cherry picked from commit 8748293)
* add automatic optimization property setter to lightning module * Update test_manual_optimization.py Co-authored-by: chaton <[email protected]> (cherry picked from commit 8748293)
* add automatic optimization property setter to lightning module * Update test_manual_optimization.py Co-authored-by: chaton <[email protected]> (cherry picked from commit 8748293)
* add automatic optimization property setter to lightning module * Update test_manual_optimization.py Co-authored-by: chaton <[email protected]> (cherry picked from commit 8748293)
* add automatic optimization property setter to lightning module * Update test_manual_optimization.py Co-authored-by: chaton <[email protected]> (cherry picked from commit 8748293)
* add automatic optimization property setter to lightning module * Update test_manual_optimization.py Co-authored-by: chaton <[email protected]> (cherry picked from commit 8748293)
* add automatic optimization property setter to lightning module * Update test_manual_optimization.py Co-authored-by: chaton <[email protected]> (cherry picked from commit 8748293)
* add automatic optimization property setter to lightning module * Update test_manual_optimization.py Co-authored-by: chaton <[email protected]> (cherry picked from commit 8748293)
* add automatic optimization property setter to lightning module * Update test_manual_optimization.py Co-authored-by: chaton <[email protected]> (cherry picked from commit 8748293)
What does this PR do?
This speeds up the deprecation of the
automatic_optimization
flag from the Trainer by making this property settable on the module. So someone could doself.automatic_optimization = False
without running into an attribute errorFixes # (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃