[bug-fix] Metric reduction with Logging #5150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5150 +/- ##
======================================
Coverage 93% 93%
======================================
Files 134 134
Lines 9905 9917 +12
======================================
+ Hits 9204 9231 +27
+ Misses 701 686 -15 |
tchaton
changed the title
tchaton
requested review from
awaelchli,
Borda,
justusschock,
SeanNaren and
williamFalcon
as code owners
…b.com/PyTorchLightning/pytorch-lightning into bugfix/5146_metrics_reduction_logging
SeanNaren
approved these changes
Dec 16, 2020
|
@teddykoker @ananyahjha93 Mind a review ? |
|
Why did you add the code to the callbacks and not where logging happens? Shouldn't the callback metrics contain the already computed/detached values? Now we have duplicated code, and each callback has to handle the Metric with this special condition? This does not look right. |
awaelchli
pushed a commit
that referenced
this pull request
Dec 18, 2020
* add test * resolve bug * udpate test * wrongly copy / paste * update test * resolve a second bug Co-authored-by: Ubuntu <[email protected]>
tchaton
added a commit
that referenced
this pull request
Dec 21, 2020
* add test * resolve bug * udpate test * wrongly copy / paste * update test * resolve a second bug Co-authored-by: Ubuntu <[email protected]>
Borda
pushed a commit
that referenced
this pull request
Dec 23, 2020
* add test * resolve bug * udpate test * wrongly copy / paste * update test * resolve a second bug Co-authored-by: Ubuntu <[email protected]>
Borda
pushed a commit
that referenced
this pull request
Dec 29, 2020
* add test * resolve bug * udpate test * wrongly copy / paste * update test * resolve a second bug Co-authored-by: Ubuntu <[email protected]>
Borda
pushed a commit
that referenced
this pull request
Jan 4, 2021
* add test * resolve bug * udpate test * wrongly copy / paste * update test * resolve a second bug Co-authored-by: Ubuntu <[email protected]>
Borda
pushed a commit
that referenced
this pull request
Jan 4, 2021
* add test * resolve bug * udpate test * wrongly copy / paste * update test * resolve a second bug Co-authored-by: Ubuntu <[email protected]>
Borda
pushed a commit
that referenced
this pull request
Jan 5, 2021
* add test * resolve bug * udpate test * wrongly copy / paste * update test * resolve a second bug Co-authored-by: Ubuntu <[email protected]>
tchaton
added a commit
that referenced
this pull request
Jan 7, 2021
…gerConnector (#5218) * [bug-fix] Metric reduction with Logging (#5150) * add test * resolve bug * udpate test * wrongly copy / paste * update test * resolve a second bug Co-authored-by: Ubuntu <[email protected]> * iupdate * resolve bugs * add test back * correct flake8 * resolve flake8 * update on comments * update tests * add a test * add test * update to Callable Co-authored-by: Ubuntu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #5146
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃