Fix reset TensorRunningAccum #5106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VinhLoiIT
requested review from
awaelchli,
Borda,
justusschock,
SeanNaren,
tchaton and
williamFalcon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #5106 +/- ##
======================================
Coverage 93% 93%
======================================
Files 134 134
Lines 9905 9905
======================================
Hits 9204 9204
Misses 701 701 |
carmocca
approved these changes
Dec 13, 2020
rohitgr7
approved these changes
Dec 13, 2020
tchaton
reviewed
Dec 14, 2020
| @@ -50,7 +50,7 @@ def __init__(self, window_length: int): | |||
|
|
|||
| def reset(self) -> None: | |||
| """Empty the accumulator.""" | |||
| self = TensorRunningAccum(self.window_length) | |||
| self.__init__(self.window_length) | |||
There was a problem hiding this comment.
Could you add a test to make sure TensorRunningAccum is having the right behaviour ?
There was a problem hiding this comment.
Sure. I've tested it manually, but I would add the test in the next commit as you suggested.
There was a problem hiding this comment.
I don't think we have tests for TensorRunningAccum, so you'll have to create them
awaelchli
approved these changes
Dec 16, 2020
awaelchli
pushed a commit
that referenced
this pull request
Dec 18, 2020
* Fix reset TensorRunningAccum * add test for TensorRunningAccum's reset method * fix CI failed due to PEP8 Co-authored-by: Rohit Gupta <[email protected]>
Borda
pushed a commit
that referenced
this pull request
Dec 23, 2020
* Fix reset TensorRunningAccum * add test for TensorRunningAccum's reset method * fix CI failed due to PEP8 Co-authored-by: Rohit Gupta <[email protected]>
Borda
pushed a commit
that referenced
this pull request
Dec 29, 2020
* Fix reset TensorRunningAccum * add test for TensorRunningAccum's reset method * fix CI failed due to PEP8 Co-authored-by: Rohit Gupta <[email protected]>
Borda
pushed a commit
that referenced
this pull request
Jan 4, 2021
* Fix reset TensorRunningAccum * add test for TensorRunningAccum's reset method * fix CI failed due to PEP8 Co-authored-by: Rohit Gupta <[email protected]>
Borda
pushed a commit
that referenced
this pull request
Jan 4, 2021
* Fix reset TensorRunningAccum * add test for TensorRunningAccum's reset method * fix CI failed due to PEP8 Co-authored-by: Rohit Gupta <[email protected]>
Borda
pushed a commit
that referenced
this pull request
Jan 5, 2021
* Fix reset TensorRunningAccum * add test for TensorRunningAccum's reset method * fix CI failed due to PEP8 Co-authored-by: Rohit Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #5073