-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enableself.log
in most functions.
#4969
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaton
requested review from
awaelchli,
Borda,
justusschock,
SeanNaren and
williamFalcon
as code owners
December 4, 2020 11:41
Codecov Report
@@ Coverage Diff @@
## master #4969 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 129 129
Lines 9363 9371 +8
======================================
+ Hits 8681 8688 +7
- Misses 682 683 +1 |
SeanNaren
reviewed
Dec 4, 2020
pytorch_lightning/trainer/connectors/logger_connector/epoch_result_store.py
Show resolved
Hide resolved
SeanNaren
reviewed
Dec 4, 2020
SeanNaren
approved these changes
Dec 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few nits but lgtm
williamFalcon
approved these changes
Dec 4, 2020
carmocca
reviewed
Dec 5, 2020
carmocca
reviewed
Dec 5, 2020
tchaton
changed the title
Enable logging in most functions.
EnableDec 5, 2020
sel.log
in most functions.
Borda
reviewed
Dec 5, 2020
Borda
reviewed
Dec 5, 2020
tchaton
changed the title
Enable
EnableDec 5, 2020
sel.log
in most functions.self.log
in most functions.
Borda
approved these changes
Dec 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR re-enables logging in most of callbacks and models functions while retaining some speed behind efficient.
We don't support logging in
batch_start
function to save 0.5 % of the entire training_epoch time.Fixes #4857
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃