Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enableself.log in most functions. #4969

Merged
merged 25 commits into from
Dec 6, 2020
Merged

Enableself.log in most functions. #4969

merged 25 commits into from
Dec 6, 2020

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Dec 4, 2020

What does this PR do?

This PR re-enables logging in most of callbacks and models functions while retaining some speed behind efficient.
We don't support logging in batch_start function to save 0.5 % of the entire training_epoch time.

Fixes #4857

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton marked this pull request as ready for review December 4, 2020 11:41
@tchaton tchaton self-assigned this Dec 4, 2020
@tchaton tchaton added logger Related to the Loggers priority: 0 High priority task labels Dec 4, 2020
@tchaton tchaton added this to the 1.1 milestone Dec 4, 2020
@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #4969 (2bc49bf) into master (9b1afa8) will decrease coverage by 0%.
The diff coverage is 96%.

@@          Coverage Diff           @@
##           master   #4969   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         129     129           
  Lines        9363    9371    +8     
======================================
+ Hits         8681    8688    +7     
- Misses        682     683    +1     

@tchaton tchaton changed the title logging refactor Enable logging in most functions. Dec 4, 2020
Copy link
Contributor

@SeanNaren SeanNaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nits but lgtm

@tchaton tchaton changed the title Enable logging in most functions. Enablesel.log in most functions. Dec 5, 2020
@tchaton tchaton changed the title Enablesel.log in most functions. Enableself.log in most functions. Dec 5, 2020
@Borda Borda added the ready PRs ready to be merged label Dec 6, 2020
@tchaton tchaton merged commit 2e838e6 into master Dec 6, 2020
@tchaton tchaton deleted the optimizer_logging_2 branch December 6, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logger Related to the Loggers priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging not working in on_train_batch_end of a callback.
5 participants