-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HotFix] Logging - One epoch delay on training epoch metrics. #4913
Merged
tchaton
merged 9 commits into
master
from
bugfix/4863_progress_bar_dict_delayed_by_one_epoch
Dec 1, 2020
Merged
[HotFix] Logging - One epoch delay on training epoch metrics. #4913
tchaton
merged 9 commits into
master
from
bugfix/4863_progress_bar_dict_delayed_by_one_epoch
Dec 1, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaton
added
bug
Something isn't working
Important
logger
Related to the Loggers
labels
Nov 30, 2020
tchaton
requested review from
ananyahjha93,
awaelchli,
Borda,
justusschock,
nateraw,
SeanNaren,
teddykoker and
williamFalcon
as code owners
November 30, 2020 13:42
Hello @tchaton! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-12-01 08:16:41 UTC |
Borda
approved these changes
Nov 30, 2020
…ttps://github.com/PyTorchLightning/pytorch-lightning into bugfix/4863_progress_bar_dict_delayed_by_one_epoch
justusschock
approved these changes
Nov 30, 2020
carmocca
approved these changes
Nov 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
SeanNaren
approved these changes
Nov 30, 2020
Codecov Report
@@ Coverage Diff @@
## master #4913 +/- ##
======================================
Coverage 93% 93%
======================================
Files 122 122
Lines 9225 9225
======================================
Hits 8545 8545
Misses 680 680 |
tchaton
deleted the
bugfix/4863_progress_bar_dict_delayed_by_one_epoch
branch
December 1, 2020 09:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR update logging logic for training.
Fixes #4863
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃