Sharded Plugin 4/n: Expose scaler in amp plugin #4737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanNaren
requested review from
ananyahjha93,
awaelchli,
Borda,
justusschock,
nateraw,
tchaton,
teddykoker and
williamFalcon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4737 +/- ##
======================================
Coverage 93% 93%
======================================
Files 117 117
Lines 8954 8957 +3
======================================
+ Hits 8321 8324 +3
Misses 633 633 |
| @@ -136,7 +136,7 @@ def setup_training(self, model: LightningModule): | |||
|
|
|||
| # init amp. Must be done here instead of __init__ to allow ddp to work | |||
| if self.trainer.amp_backend == AMPType.NATIVE and self.trainer.precision == 16 and not self.trainer.use_tpu: | |||
There was a problem hiding this comment.
for a future PR let's fold these if statements into accelerators
williamFalcon
approved these changes
Nov 18, 2020
Borda
approved these changes
Nov 18, 2020
awaelchli
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related to #4178
Allows precision plugin to manage grad scaler. This is needed for Sharded as we require a custom scaler object.
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃