Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current_score to ModelCheckpoint.on_save_checkpoint #4721

Merged
merged 10 commits into from
Nov 18, 2020
Merged

Add current_score to ModelCheckpoint.on_save_checkpoint #4721

merged 10 commits into from
Nov 18, 2020

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Nov 17, 2020

What does this PR do?

Fixes #4712

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • [n/a] Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

[ci skip]
@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #4721 (8a8ef37) into master (ece09f0) will increase coverage by 3%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #4721    +/-   ##
=======================================
+ Coverage      90%     93%    +3%     
=======================================
  Files         117     117            
  Lines        8937    8939     +2     
=======================================
+ Hits         8056    8306   +250     
+ Misses        881     633   -248     

Co-authored-by: Rohit Gupta <[email protected]>
@Borda Borda added bug Something isn't working checkpointing Related to checkpointing labels Nov 17, 2020
@rohitgr7 rohitgr7 added ready PRs ready to be merged feature Is an improvement or enhancement and removed bug Something isn't working labels Nov 18, 2020
@rohitgr7 rohitgr7 added this to the 1.1 milestone Nov 18, 2020
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea !

@tchaton tchaton merged commit 396a46f into Lightning-AI:master Nov 18, 2020
@carmocca carmocca deleted the feature/4712_add-score branch November 18, 2020 12:01
rohitgr7 added a commit that referenced this pull request Nov 21, 2020
* Add current_score to ModelCheckpoint.on_save_checkpoint

* Update CHANGELOG

[ci skip]

* fix

Co-authored-by: Rohit Gupta <[email protected]>

* fix2

* Add test for NaN

* Fix failing tests

* Simplify line

* Add test docstrings

Co-authored-by: chaton <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Rohit Gupta <[email protected]>
@carmocca carmocca self-assigned this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
checkpointing Related to checkpointing feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add current_model_score to ModelCheckpoint.on_save_checkpoint
5 participants