-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add current_score to ModelCheckpoint.on_save_checkpoint #4721
Merged
tchaton
merged 10 commits into
Lightning-AI:master
from
carmocca:feature/4712_add-score
Nov 18, 2020
Merged
Add current_score to ModelCheckpoint.on_save_checkpoint #4721
tchaton
merged 10 commits into
Lightning-AI:master
from
carmocca:feature/4712_add-score
Nov 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip]
rohitgr7
reviewed
Nov 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #4721 +/- ##
=======================================
+ Coverage 90% 93% +3%
=======================================
Files 117 117
Lines 8937 8939 +2
=======================================
+ Hits 8056 8306 +250
+ Misses 881 633 -248 |
Co-authored-by: Rohit Gupta <[email protected]>
Borda
reviewed
Nov 17, 2020
s-rog
reviewed
Nov 18, 2020
s-rog
approved these changes
Nov 18, 2020
rohitgr7
approved these changes
Nov 18, 2020
tchaton
approved these changes
Nov 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea !
rohitgr7
added a commit
that referenced
this pull request
Nov 21, 2020
* Add current_score to ModelCheckpoint.on_save_checkpoint * Update CHANGELOG [ci skip] * fix Co-authored-by: Rohit Gupta <[email protected]> * fix2 * Add test for NaN * Fix failing tests * Simplify line * Add test docstrings Co-authored-by: chaton <[email protected]> Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Rohit Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
checkpointing
Related to checkpointing
feature
Is an improvement or enhancement
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4712
Before submitting
PR review