Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate auto mode from ModelCheckpoint and EarlyStopping #4695

Merged
merged 14 commits into from
Dec 4, 2020
Merged

Deprecate auto mode from ModelCheckpoint and EarlyStopping #4695

merged 14 commits into from
Dec 4, 2020

Conversation

rohitgr7
Copy link
Contributor

What does this PR do?

Fixes #4668

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified; Bugfixes should be including in bug-fix release milestones (m.f.X) and features should be included in (m.X.b) releases.

Did you have fun?

Make sure you had fun coding 🙃

@rohitgr7 rohitgr7 added feature Is an improvement or enhancement design Includes a design discussion checkpointing Related to checkpointing labels Nov 16, 2020
@rohitgr7 rohitgr7 added this to the 1.1 milestone Nov 16, 2020
@rohitgr7 rohitgr7 marked this pull request as ready for review November 16, 2020 15:21
@codecov
Copy link

codecov bot commented Nov 16, 2020 •
edited
Loading

Codecov Report

Merging #4695 (a64e353) into master (b807c32) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4695   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         124     124           
  Lines        9291    9294    +3     
======================================
+ Hits         8604    8608    +4     
+ Misses        687     686    -1

Borda
Borda requested changes Nov 16, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to update docs

CHANGELOG.md Outdated Show resolved Hide resolved
@rohitgr7 rohitgr7 requested a review from Borda November 16, 2020 19:08
carmocca
carmocca approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rohitgr7 rohitgr7 requested a review from Borda November 17, 2020 19:37
@pep8speaks
Copy link

pep8speaks commented Nov 18, 2020 •
edited
Loading

Hello @rohitgr7! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-12-03 09:44:00 UTC

tchaton
tchaton approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Borda
Borda reviewed Nov 18, 2020
View reviewed changes
tests/test_deprecated.py Outdated Show resolved Hide resolved
awaelchli
awaelchli approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very reasonable PR <3
@rohitgr7 did you do a full text search for mode=auto across the whole project?

Borda
Borda approved these changes Nov 18, 2020
View reviewed changes
docs/source/weights_loading.rst Outdated Show resolved Hide resolved
tests/test_deprecated.py Outdated Show resolved Hide resolved
@rohitgr7
Copy link
Contributor Author

@rohitgr7 did you do a full text search for mode=auto across the whole project?

yes @awaelchli

@rohitgr7
Copy link
Contributor Author

@williamFalcon this needs your approval.

@rohitgr7 rohitgr7 added the ready PRs ready to be merged label Nov 25, 2020
@rohitgr7
Copy link
Contributor Author

rohitgr7 commented Dec 2, 2020

@williamFalcon mind review?

@Borda Borda merged commit 342a2b6 into master Dec 4, 2020
@Borda Borda deleted the rm_auto_mode branch December 4, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpariente mpariente mpariente left review comments

@carmocca carmocca carmocca approved these changes

@awaelchli awaelchli awaelchli approved these changes

@s-rog s-rog s-rog approved these changes

@manbldwin manbldwin manbldwin approved these changes

@ydcjeff ydcjeff ydcjeff approved these changes

@justusschock justusschock justusschock approved these changes

@tchaton tchaton tchaton approved these changes

@Borda Borda Borda approved these changes

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@nateraw nateraw Awaiting requested review from nateraw

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@teddykoker teddykoker Awaiting requested review from teddykoker

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@edenlightning edenlightning Awaiting requested review from edenlightning

Assignees
No one assigned
Labels
checkpointing Related to checkpointing design Includes a design discussion feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.1
Development

Successfully merging this pull request may close these issues.

ModelCheckpoint automatic mode selection is misleading