-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix visual progress bar bug / properly reset progress bar #4579
Conversation
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions. |
This pull request is going to be closed. Please feel free to reopen it create a new from the actual master. |
Codecov Report
@@ Coverage Diff @@
## master #4579 +/- ##
======================================
Coverage 93% 93%
======================================
Files 135 135
Lines 10003 10006 +3
======================================
+ Hits 9326 9329 +3
Misses 677 677 |
Co-authored-by: Carlos Mocholí <[email protected]>
would be fine to merge it after #5495 |
* reset * fix reset * changelog * update chlog * typing Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: Carlos Mocholí <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <[email protected]>
What does this PR do?
Fixes #4567
A visual bug occurs at the very initial state of the progress bar:
It shows "0 it" and the total is not displayed. But we can make it show just 0% like so:
by calling the
tqdm.reset()
method instead of manually setting the total amount.This is very hard to spot, because the progress bar usually updates very fast. You have to add a
time.sleep
to the training loop to observe it.