Replace a MisconfigurationException with warning in ModelCheckpoint callback #4560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazhang
requested review from
ananyahjha93,
awaelchli,
Borda,
justusschock,
nateraw,
SeanNaren,
tchaton,
teddykoker and
williamFalcon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4560 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 116 116
Lines 8855 8854 -1
======================================
- Hits 8248 8244 -4
- Misses 607 610 +3 |
awaelchli
approved these changes
Nov 8, 2020
Comment on lines
297
to
300
| with pytest.raises( | ||
| MisconfigurationException, match=r'ModelCheckpoint\(save_last=True, monitor=None\) is not a valid.*' | ||
| ): | ||
| ModelCheckpoint(dirpath=tmpdir, save_last=True) |
There was a problem hiding this comment.
you can convert this to pytest.warns(UserWarning, ...
SeanNaren
pushed a commit
that referenced
this pull request
Nov 11, 2020
…allback (#4560) * replace MisconfigurationException with warning * update test * check raising UserWarning Co-authored-by: chaton <[email protected]> Co-authored-by: Nicki Skafte <[email protected]> (cherry picked from commit 30ad3e2)
Borda
pushed a commit
that referenced
this pull request
Nov 11, 2020
…allback (#4560) * replace MisconfigurationException with warning * update test * check raising UserWarning Co-authored-by: chaton <[email protected]> Co-authored-by: Nicki Skafte <[email protected]> (cherry picked from commit 30ad3e2)
rohitgr7
pushed a commit
that referenced
this pull request
Nov 21, 2020
…allback (#4560) * replace MisconfigurationException with warning * update test * check raising UserWarning Co-authored-by: chaton <[email protected]> Co-authored-by: Nicki Skafte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I have a custom checkpoint callback that inherits from the
ModelCheckpointcallback to supportevery_n_stepsby saving all(save_top_k=-1andmonitor=None) and skip if not every n steps ((global_step + 1) % every_n_steps != 0)At the same time, I also want to store the last checkpoint(
save_last=True) so that we could resume training from crash.However, this exception prevent me from doing so.
This PR replace the exception with a warning as discussed in #4335
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In in short, see following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃