Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_picklable: catch AttributeError (addresses #3771) #4508

Merged
merged 4 commits into from
Nov 4, 2020

Conversation

jtamir
Copy link
Contributor

@jtamir jtamir commented Nov 4, 2020

What does this PR do?

Adds an error catch for AttributeError in the utilities.parser.is_picklable function.

Fixes #3771

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Nov 4, 2020

Codecov Report

Merging #4508 into master will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #4508   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         116     116           
  Lines        8718    8718           
======================================
- Hits         8086    8075   -11     
- Misses        632     643   +11     

@Borda Borda added the bug Something isn't working label Nov 4, 2020
@Borda Borda added this to the 1.0.x milestone Nov 4, 2020
pytorch_lightning/utilities/parsing.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch !

@Borda Borda added the ready PRs ready to be merged label Nov 4, 2020
@rohitgr7 rohitgr7 merged commit 945d6f5 into Lightning-AI:master Nov 4, 2020
SeanNaren pushed a commit that referenced this pull request Nov 10, 2020
* is_picklable: catch AttributeError (addresses #3771)

* edit

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: chaton <[email protected]>
(cherry picked from commit 945d6f5)
SeanNaren pushed a commit that referenced this pull request Nov 11, 2020
* is_picklable: catch AttributeError (addresses #3771)

* edit

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: chaton <[email protected]>
(cherry picked from commit 945d6f5)
rohitgr7 pushed a commit that referenced this pull request Nov 21, 2020
* is_picklable: catch AttributeError (addresses #3771)

* edit

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: chaton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling AttributeErrors while cleaning params namespace while setting up fit
6 participants