-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
is_picklable: catch AttributeError (addresses #3771) #4508
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtamir
requested review from
ananyahjha93,
awaelchli,
Borda,
justusschock,
nateraw,
SeanNaren,
tchaton,
teddykoker and
williamFalcon
as code owners
November 4, 2020 06:08
Codecov Report
@@ Coverage Diff @@
## master #4508 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 116 116
Lines 8718 8718
======================================
- Hits 8086 8075 -11
- Misses 632 643 +11 |
Borda
approved these changes
Nov 4, 2020
tchaton
approved these changes
Nov 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch !
awaelchli
approved these changes
Nov 4, 2020
ydcjeff
approved these changes
Nov 4, 2020
SeanNaren
pushed a commit
that referenced
this pull request
Nov 10, 2020
* is_picklable: catch AttributeError (addresses #3771) * edit Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: chaton <[email protected]> (cherry picked from commit 945d6f5)
SeanNaren
pushed a commit
that referenced
this pull request
Nov 11, 2020
* is_picklable: catch AttributeError (addresses #3771) * edit Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: chaton <[email protected]> (cherry picked from commit 945d6f5)
rohitgr7
pushed a commit
that referenced
this pull request
Nov 21, 2020
* is_picklable: catch AttributeError (addresses #3771) * edit Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: chaton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an error catch for AttributeError in the
utilities.parser.is_picklable
function.Fixes #3771
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃