-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wandb): log in sync with Trainer step #4405
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borisdayma
requested review from
ananyahjha93,
awaelchli,
Borda,
justusschock,
nateraw,
SeanNaren,
tchaton,
teddykoker and
williamFalcon
as code owners
October 28, 2020 01:07
Codecov Report
@@ Coverage Diff @@
## master #4405 +/- ##
======================================
Coverage 93% 93%
======================================
Files 111 111
Lines 8081 8081
======================================
Hits 7489 7489
Misses 592 592 |
justusschock
approved these changes
Oct 28, 2020
SkafteNicki
approved these changes
Oct 28, 2020
awaelchli
approved these changes
Oct 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
awaelchli
added
logger
Related to the Loggers
feature
Is an improvement or enhancement
labels
Oct 28, 2020
rohitgr7
approved these changes
Oct 28, 2020
Borda
pushed a commit
that referenced
this pull request
Nov 4, 2020
* feat(wandb): log in sync with Trainer step * docs: update CHANGELOG * style(test_wandb): fix formatting * parentheses Co-authored-by: Adrian Wälchli <[email protected]> Co-authored-by: Rohit Gupta <[email protected]> (cherry picked from commit ff41d80)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses directly
Trainer
step to log metrics and keep it in sync with wandb step.They were decoupled due to an issue on k-fold logging, where we use multiple
Trainer
for the same W&B run.This created confusion for some users as
wandb
was then usingglobal_step
as a parameter to refer toTrainer
step.global_step
is not used anymore and instead, we offsetstep
when logging additionalTrainer
loops on the same W&B run.Fixes #4113
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃