-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optimizer hooks in callbacks #4379
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4379 +/- ##
=======================================
+ Coverage 90% 93% +3%
=======================================
Files 111 111
Lines 8159 8044 -115
=======================================
+ Hits 7306 7465 +159
+ Misses 853 579 -274 |
Failing windows tests coming from master. |
rohitgr7
requested review from
ananyahjha93,
awaelchli,
Borda,
justusschock,
nateraw,
SeanNaren,
tchaton,
teddykoker and
williamFalcon
as code owners
October 27, 2020 18:02
justusschock
approved these changes
Oct 28, 2020
SkafteNicki
approved these changes
Oct 28, 2020
ydcjeff
changed the title
Add optimizer hooks in callbacks [skip ci]
Add optimizer hooks in callbacks
Oct 28, 2020
ydcjeff
approved these changes
Oct 28, 2020
SeanNaren
pushed a commit
that referenced
this pull request
Nov 10, 2020
* Add optimizer hooks in callbacks * optimizer param * update test Co-authored-by: Nicki Skafte <[email protected]> (cherry picked from commit b26c71e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3657
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃