Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optimizer hooks in callbacks #4379

Merged
merged 4 commits into from
Oct 28, 2020
Merged

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Oct 26, 2020

What does this PR do?

Fixes #3657

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@rohitgr7 rohitgr7 added feature Is an improvement or enhancement callback labels Oct 26, 2020
@rohitgr7 rohitgr7 added this to the 1.0.x milestone Oct 26, 2020
@codecov
Copy link

codecov bot commented Oct 26, 2020

Codecov Report

Merging #4379 into master will increase coverage by 3%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #4379    +/-   ##
=======================================
+ Coverage      90%     93%    +3%     
=======================================
  Files         111     111            
  Lines        8159    8044   -115     
=======================================
+ Hits         7306    7465   +159     
+ Misses        853     579   -274     

@rohitgr7
Copy link
Contributor Author

Failing windows tests coming from master.

@rohitgr7 rohitgr7 marked this pull request as ready for review October 27, 2020 18:02
@mergify mergify bot requested a review from a team October 27, 2020 18:02
@ydcjeff ydcjeff changed the title Add optimizer hooks in callbacks [skip ci] Add optimizer hooks in callbacks Oct 28, 2020
@SkafteNicki SkafteNicki merged commit b26c71e into master Oct 28, 2020
@rohitgr7 rohitgr7 deleted the enhance/optim_callback_hooks branch October 28, 2020 12:29
@edenlightning edenlightning modified the milestones: 1.0.x, 1.1 Nov 4, 2020
SeanNaren pushed a commit that referenced this pull request Nov 10, 2020
* Add optimizer hooks in callbacks

* optimizer param

* update test

Co-authored-by: Nicki Skafte <[email protected]>
(cherry picked from commit b26c71e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
callback feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add on_after_backwards callback option
5 participants