timeout for tpu check #4340
Merged
timeout for tpu check #4340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lezwon
requested review from
ananyahjha93,
awaelchli,
Borda,
justusschock,
nateraw,
SeanNaren,
tchaton,
teddykoker and
williamFalcon
as code owners
Codecov Report
@@ Coverage Diff @@
## master #4340 +/- ##
======================================
- Coverage 93% 93% -0%
======================================
Files 113 113
Lines 8192 8192
======================================
- Hits 7624 7621 -3
- Misses 568 571 +3 |
lezwon
force-pushed
the
bugfix/4324_xla_timeout
branch
from
183023e to
30d7a94
Compare
lezwon
commented
Oct 25, 2020
lezwon
added
bug
Borda
reviewed
Oct 25, 2020
|
This pull request is now in conflict... :( |
|
@lezwon mind rebasing? |
lezwon
force-pushed
the
bugfix/4324_xla_timeout
branch
from
7999b31 to
7283d25
Compare
awaelchli
approved these changes
Oct 28, 2020
SeanNaren
approved these changes
Oct 31, 2020
rohitgr7
approved these changes
Oct 31, 2020
Borda
pushed a commit
that referenced
this pull request
Nov 4, 2020
* timeout for tpu check * added tests * updated CHANGELOG.md * fixed windows tests * Update pytorch_lightning/utilities/xla_device_utils.py Co-authored-by: Jirka Borovec <[email protected]> * requested changes Co-authored-by: Jirka Borovec <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]> (cherry picked from commit 839813e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4324
This PR adds a timeout of 10 secs to the process which is used to fetch the type of XLA device. This ensures that the process does not hang indefinitely and does not block the importing of lightning as in the case of #4324.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃