BUG - Wandb: Sanitize callable. #4320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaton
requested review from
ananyahjha93,
awaelchli,
Borda,
justusschock,
nateraw,
SeanNaren,
teddykoker and
williamFalcon
as code owners
|
Hello @tchaton! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-10-26 11:22:31 UTC |
Codecov Report
@@ Coverage Diff @@
## master #4320 +/- ##
======================================
Coverage 93% 93%
======================================
Files 111 111
Lines 8049 8063 +14
======================================
+ Hits 7469 7483 +14
Misses 580 580 |
SeanNaren
reviewed
Oct 23, 2020
SeanNaren
approved these changes
Oct 23, 2020
awaelchli
approved these changes
Oct 23, 2020
Co-authored-by: Adrian Wälchli <[email protected]>
Borda
reviewed
Oct 23, 2020
| @@ -138,3 +138,4 @@ mlruns/ | |||
| *.ckpt | |||
| pytorch\ lightning | |||
| test-reports/ | |||
| wandb | |||
There was a problem hiding this comment.
how it happens that this folder is created?
There was a problem hiding this comment.
wandb logger always makes this folder, we can't avoid this. I have it too. I think it's ok to add it to gitignore.
|
This pull request is now in conflict... :( |
SkafteNicki
approved these changes
Oct 25, 2020
awaelchli
reviewed
Oct 26, 2020
| return val.__name__ | ||
| return _val | ||
| except Exception: | ||
| return val.__name__ |
There was a problem hiding this comment.
see #4380, not all objects have __name__
maybe we need __class__.__name__
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR add sanitisation for
Trainer.add_argparse_argswhich could be function.Behaviour:
Fixes #4276
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃