Skip to content

Load checkpoint from Bytes #4314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 23, 2020
Merged

Load checkpoint from Bytes #4314

merged 8 commits into from
Oct 23, 2020

Conversation

teddykoker
Copy link
Contributor

@teddykoker teddykoker commented Oct 22, 2020

What does this PR do?

Prior to the introduction of fspec in load_from_checkpoint, users could load any arbitrary bytes as it was just using torch.load under the hood. This restores that ability, but does not affect any additional use cases involving fspec.

@teddykoker teddykoker changed the title Load checkpoint from Bytes Load checkpoint from Bytes [WIP] Oct 22, 2020
@mergify mergify bot requested a review from a team October 22, 2020 21:49
@teddykoker teddykoker marked this pull request as draft October 22, 2020 21:50
@williamFalcon
Copy link
Contributor

cc @ananthsub

@Lightning-AI Lightning-AI deleted a comment from pep8speaks Oct 22, 2020
@teddykoker teddykoker marked this pull request as ready for review October 22, 2020 22:27
@teddykoker teddykoker changed the title Load checkpoint from Bytes [WIP] Load checkpoint from Bytes Oct 22, 2020
@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #4314 into master will increase coverage by 0%.
The diff coverage is 80%.

@@          Coverage Diff           @@
##           master   #4314   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         111     111           
  Lines        8060    8019   -41     
======================================
- Hits         7461    7457    -4     
+ Misses        599     562   -37     

@ydcjeff ydcjeff added the feature Is an improvement or enhancement label Oct 23, 2020
@ydcjeff ydcjeff added this to the 1.0.x milestone Oct 23, 2020
@mergify mergify bot requested a review from a team October 23, 2020 07:25
@teddykoker teddykoker merged commit 91c64e9 into master Oct 23, 2020
@teddykoker teddykoker deleted the load_bytes branch October 23, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants