-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Load checkpoint from Bytes #4314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @ananthsub |
Codecov Report
@@ Coverage Diff @@
## master #4314 +/- ##
======================================
Coverage 93% 93%
======================================
Files 111 111
Lines 8060 8019 -41
======================================
- Hits 7461 7457 -4
+ Misses 599 562 -37 |
ananthsub
approved these changes
Oct 23, 2020
justusschock
approved these changes
Oct 23, 2020
tchaton
approved these changes
Oct 23, 2020
s-rog
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prior to the introduction of fspec in
load_from_checkpoint
, users could load any arbitrary bytes as it was just usingtorch.load
under the hood. This restores that ability, but does not affect any additional use cases involving fspec.