-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOTFIX] ModelCheckpoint - Don't increase current_epoch and global_step if not trained #4291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @tchaton! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-10-23 08:26:50 UTC |
tchaton
changed the title
add two tests w/wo tempdir
Add two tests w/wo tempdir for saving / restoring from ModelCheckpoint
Oct 21, 2020
tchaton
requested review from
ananyahjha93,
awaelchli,
Borda,
justusschock,
nateraw,
SeanNaren,
teddykoker and
williamFalcon
as code owners
October 22, 2020 07:22
justusschock
approved these changes
Oct 22, 2020
Codecov Report
@@ Coverage Diff @@
## master #4291 +/- ##
======================================
Coverage 93% 93%
======================================
Files 111 111
Lines 8007 8017 +10
======================================
+ Hits 7445 7456 +11
+ Misses 562 561 -1 |
tchaton
changed the title
Add two tests w/wo tempdir for saving / restoring from ModelCheckpoint
[WIP] MisconfigurationException: restored ckpt with current_epoch=2, but the Trainer(max_epochs=1)
Oct 22, 2020
…ithub.com/PyTorchLightning/pytorch-lightning into hotfix/issue_4176_repeated_save_restore_2
…ithub.com/PyTorchLightning/pytorch-lightning into hotfix/issue_4176_repeated_save_restore_2
tchaton
changed the title
[WIP] MisconfigurationException: restored ckpt with current_epoch=2, but the Trainer(max_epochs=1)
[HOTFIX] ModelCheckpoint - Don't increase current_epoch and global_step if not trained
Oct 22, 2020
teddykoker
approved these changes
Oct 22, 2020
This pull request is now in conflict... :( |
SeanNaren
approved these changes
Oct 23, 2020
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR resolve the bug associated with increasing current_epoch and global_step when iteratively dumping / restoring train.
Fixes #4176
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃