Bugfix/4156 filter hparams for yaml - fsspec #4158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
requested review from
justusschock,
williamFalcon,
awaelchli,
ananyahjha93,
nateraw,
teddykoker and
yukw777
teddykoker
approved these changes
Oct 14, 2020
Codecov Report
@@ Coverage Diff @@
## master #4158 +/- ##
======================================
Coverage 93% 93%
======================================
Files 103 103
Lines 7805 7813 +8
======================================
+ Hits 7239 7247 +8
Misses 566 566 |
justusschock
approved these changes
Oct 15, 2020
tchaton
previously requested changes
Oct 15, 2020
| hparams_allowed = {} | ||
| # drop paramaters which contain some strange datatypes as fsspec | ||
| for k, v in hparams.items(): | ||
| try: |
There was a problem hiding this comment.
Hey @Borda, I was wondering if it makes sense to force dumping to yaml file. It might break reproducibility for some use cases. But for the yaml format, we could also support some conversion like: tensor and numpy array to list, etc...
There was a problem hiding this comment.
so how else would you test that some value/data are not possible to dum, I have not found any method like is_dumpable and most examples use this construct...
|
This pull request is now in conflict... :( |
Co-authored-by: Justus Schock <[email protected]>
Borda
force-pushed
the
bugfix/4156_yaml-fsspec
branch
from
839e655 to
75a2134
Compare
SkafteNicki
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #4156
BTW, this is needed for unblocking Bolts
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃