Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: decouple apex second attemp part 7/n #4061

Merged
merged 3 commits into from
Oct 10, 2020
Merged

ref: decouple apex second attemp part 7/n #4061

merged 3 commits into from
Oct 10, 2020

Conversation

williamFalcon
Copy link
Contributor

ref: decouple apex second attemp part 7/n

@pep8speaks
Copy link

Hello @williamFalcon! Thanks for opening this PR.

Line 49:121: E501 line too long (122 > 120 characters)

Do see the Hitchhiker's guide to code style

@mergify mergify bot requested a review from a team October 10, 2020 20:06
@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #4061 into master will increase coverage by 3%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #4061    +/-   ##
=======================================
+ Coverage      89%     92%    +3%     
=======================================
  Files         107     107            
  Lines        7927    7935     +8     
=======================================
+ Hits         7036    7314   +278     
+ Misses        891     621   -270     

@williamFalcon williamFalcon merged commit 5ce9fc6 into master Oct 10, 2020
@williamFalcon williamFalcon deleted the px7 branch October 11, 2020 11:35
@Borda Borda added the refactor label Oct 13, 2020
@Borda Borda added this to the 1.0 milestone Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants