Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to print scaler value in progress bar #4053

Merged
merged 4 commits into from
Oct 10, 2020
Merged

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Oct 10, 2020

What does this PR do?

Fixes #4020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team October 10, 2020 13:37
@rohitgr7 rohitgr7 changed the title Fix to print scaler value in progress bar [WIP] Fix to print scaler value in progress bar Oct 10, 2020
@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #4053 into master will decrease coverage by 2%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #4053    +/-   ##
=======================================
- Coverage      92%     90%    -2%     
=======================================
  Files         105     105            
  Lines        7814    7987   +173     
=======================================
+ Hits         7197    7217    +20     
- Misses        617     770   +153     

@rohitgr7 rohitgr7 changed the title [WIP] Fix to print scaler value in progress bar Fix to print scaler value in progress bar Oct 10, 2020
@williamFalcon williamFalcon merged commit bdbf846 into master Oct 10, 2020
@rohitgr7 rohitgr7 deleted the bugfix/pb_metrics branch October 10, 2020 16:21
@Borda Borda added the refactor label Oct 13, 2020
@Borda Borda added this to the 1.0 milestone Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation loss Tensor object is print in progress bar, it is expected only value
3 participants