Add Metric <-> Lightning Module integration tests #4008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teddykoker
requested review from
ananyahjha93,
awaelchli,
Borda and
justusschock
and removed request for
a team
|
Hello @teddykoker! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-10-09 01:27:55 UTC |
Codecov Report
@@ Coverage Diff @@
## master #4008 +/- ##
=======================================
+ Coverage 87% 89% +2%
=======================================
Files 212 212
Lines 15499 15562 +63
=======================================
+ Hits 13519 13873 +354
+ Misses 1980 1689 -291 |
Borda
reviewed
Oct 8, 2020
| return self.step(x) | ||
|
|
||
| def training_epoch_end(self, outs): | ||
| assert torch.allclose(self.sum, self.metric.compute()) |
There was a problem hiding this comment.
now much close, lets spec tolerance, also why not exact?
There was a problem hiding this comment.
default tolerance is 1e-8, i can parameterize if you want. Can't do exact bc of floating point
ananyahjha93
force-pushed
the
metric_lightning_test
branch
from
e971945 to
73338d0
Compare
ananyahjha93
force-pushed
the
metric_lightning_test
branch
from
73338d0 to
e517ac9
Compare
ananyahjha93
reviewed
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Lightning integration with metrics