remove deprecated model hooks #3980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3980 +/- ##
=======================================
- Coverage 89% 87% -2%
=======================================
Files 216 216
Lines 15569 15557 -12
=======================================
- Hits 13870 13580 -290
- Misses 1699 1977 +278 |
ydcjeff
reviewed
Oct 8, 2020
| @@ -40,15 +40,13 @@ Training loop | |||
| ^^^^^^^^^^^^^ | |||
|
|
|||
| - :meth:`~pytorch_lightning.core.hooks.ModelHooks.on_epoch_start` | |||
| - :meth:`~pytorch_lightning.core.hooks.ModelHooks.on_batch_start` | |||
There was a problem hiding this comment.
shall we add on_train_batch_start?
There was a problem hiding this comment.
Good point, mind make it as suggestion here?
There was a problem hiding this comment.
Github shows Applying suggestions on deleted line is not supported.
- :meth:`~pytorch_lightning.core.hooks.ModelHooks.on_train_batch_start`
| - :meth:`~pytorch_lightning.core.lightning.LightningModule.tbptt_split_batch` | ||
| - :meth:`~pytorch_lightning.core.lightning.LightningModule.training_step` | ||
| - :meth:`~pytorch_lightning.core.lightning.LightningModule.training_step_end` (optional) | ||
| - :meth:`~pytorch_lightning.core.hooks.ModelHooks.on_before_zero_grad` | ||
| - :meth:`~pytorch_lightning.core.hooks.ModelHooks.backward` | ||
| - :meth:`~pytorch_lightning.core.hooks.ModelHooks.on_after_backward` | ||
| - ``optimizer.step()`` | ||
| - :meth:`~pytorch_lightning.core.hooks.ModelHooks.on_batch_end` |
There was a problem hiding this comment.
here on_train_batch_end too?
There was a problem hiding this comment.
- :meth:`~pytorch_lightning.core.hooks.ModelHooks.on_train_batch_end`
|
@Borda follow up on the next PR with adding those missing hooks
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
remove deprecated model hooks
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃