Mocking Loggers (part 3c, comet) #3859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @awaelchli! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-10-05 02:23:45 UTC |
Codecov Report
@@ Coverage Diff @@
## tests/mock-comet-2 #3859 +/- ##
====================================================
- Coverage 83% 33% -50%
====================================================
Files 117 117
Lines 9103 9042 -61
====================================================
- Hits 7584 3017 -4567
- Misses 1519 6025 +4506 |
williamFalcon
pushed a commit
that referenced
this pull request
Oct 6, 2020
* ref * Mocking Loggers (part 3c, comet) (#3859) * mock comet * new line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comes after #3853
Part 3 of comet mocking, step by step
we mock the comet logger in order to run tests without installing the comet dependency.
next PR will take care of comet tests in loggers/test_all.py