Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate early_stop_callback Trainer argument (part 2) #3845

Merged
merged 6 commits into from
Oct 4, 2020

Conversation

awaelchli
Copy link
Contributor

In this PR, we replace all

Trainer(early_stop_callback=True)

in tests with

Trainer(callbacks=[EarlyStopping()])

Part 3 will follow up with the removal of Trainer(early_stop_callback=False) to keep PRs small

@awaelchli awaelchli added design Includes a design discussion v1.0 allowed labels Oct 4, 2020
@mergify mergify bot requested a review from a team October 4, 2020 17:54
@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #3845 into master will decrease coverage by 2%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #3845    +/-   ##
=======================================
- Coverage      88%     86%    -2%     
=======================================
  Files         115     115            
  Lines        8909    9101   +192     
=======================================
+ Hits         7806    7837    +31     
- Misses       1103    1264   +161     

@williamFalcon williamFalcon merged commit cc9781a into master Oct 4, 2020
@awaelchli awaelchli deleted the deprecate-es branch October 4, 2020 21:41
@Borda Borda added this to the 0.10.0 milestone Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants