Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: adding compute environments (2/n) #3842

Merged
merged 4 commits into from
Oct 4, 2020
Merged

ref: adding compute environments (2/n) #3842

merged 4 commits into from
Oct 4, 2020

Conversation

williamFalcon
Copy link
Contributor

@williamFalcon williamFalcon commented Oct 4, 2020

Continuing refactors to fix the cpu spawn issues and give users the ability to pass in their own environments.

Next steps will pass the environment to the accelerators

@mergify mergify bot requested a review from a team October 4, 2020 12:19
@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #3842 into master will decrease coverage by 0%.
The diff coverage is 68%.

@@          Coverage Diff           @@
##           master   #3842   +/-   ##
======================================
- Coverage      88%     88%   -0%     
======================================
  Files         115     115           
  Lines        8893    8917   +24     
======================================
+ Hits         7798    7814   +16     
- Misses       1095    1103    +8     

@williamFalcon williamFalcon merged commit 2c21f7d into master Oct 4, 2020
@williamFalcon williamFalcon deleted the slu3 branch October 4, 2020 17:37
@Borda Borda added the refactor label Oct 4, 2020
@Borda Borda added this to the 0.10.0 milestone Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants