Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tbptt_reduce_fx when non-floating tensors are logged #3796

Merged
merged 2 commits into from
Oct 4, 2020
Merged

Fix tbptt_reduce_fx when non-floating tensors are logged #3796

merged 2 commits into from
Oct 4, 2020

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Oct 2, 2020

What does this PR do?

Fixes #3778

Questions:

  • Not sure if that is the best file for the test
  • See TODO at the end of the test

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • [n/a] Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] If you made a notable change (that affects users), did you update the CHANGELOG?

@Borda Borda added the bug Something isn't working label Oct 2, 2020
@Borda
Copy link
Member

Borda commented Oct 2, 2020

@carmocca nice of test-driven, starting with failing test... :]

@edenlightning edenlightning added this to the 1.0 milestone Oct 4, 2020
@williamFalcon
Copy link
Contributor

i'm finishing this

@williamFalcon williamFalcon marked this pull request as ready for review October 4, 2020 20:47
@mergify mergify bot requested a review from a team October 4, 2020 20:47
@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #3796 into master will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #3796   +/-   ##
======================================
  Coverage      87%     87%           
======================================
  Files         117     117           
  Lines        9107    9107           
======================================
+ Hits         7966    7967    +1     
+ Misses       1141    1140    -1     

@williamFalcon williamFalcon merged commit 89cc123 into Lightning-AI:master Oct 4, 2020
@Borda Borda modified the milestones: 1.0, 0.10.0 Oct 7, 2020
@carmocca carmocca deleted the bug/3778 branch October 12, 2020 22:06
@carmocca carmocca self-assigned this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

training_step log requires that tbptt_reduce_fx is also set
4 participants