Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dist lib to enable syncing anything across devices #3762

Merged
merged 53 commits into from
Oct 1, 2020
Merged

Conversation

williamFalcon
Copy link
Contributor

@williamFalcon williamFalcon commented Oct 1, 2020

Rank_zero_only decorators have caused some asymmetries in the children processes. Here we eliminate those to enable ddp to work as expected and minimize other issues.

Blocker for anything that required syncing

@mergify mergify bot requested a review from a team October 1, 2020 03:57
@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #3762 into master will increase coverage by 5%.
The diff coverage is 62%.

@@           Coverage Diff           @@
##           master   #3762    +/-   ##
=======================================
+ Coverage      85%     90%    +5%     
=======================================
  Files         108     110     +2     
  Lines        8433    8436     +3     
=======================================
+ Hits         7191    7614   +423     
+ Misses       1242     822   -420     

@williamFalcon williamFalcon merged commit a38d108 into master Oct 1, 2020
@Borda Borda added the bug Something isn't working label Oct 1, 2020
@Borda Borda deleted the ppp1 branch October 2, 2020 10:07
@Borda Borda added this to the 0.10.0 milestone Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants