Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added gradient clip test for native AMP #3754

Merged
merged 2 commits into from
Oct 1, 2020
Merged

Added gradient clip test for native AMP #3754

merged 2 commits into from
Oct 1, 2020

Conversation

teddykoker
Copy link
Contributor

What does this PR do?

Avoid repeat of #1381

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Sep 30, 2020

Hello @teddykoker! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-09-30 21:17:33 UTC

@mergify mergify bot requested a review from a team September 30, 2020 21:17
@teddykoker teddykoker added ready PRs ready to be merged ci Continuous Integration labels Sep 30, 2020
@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #3754 into master will increase coverage by 7%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #3754    +/-   ##
=======================================
+ Coverage      83%     90%    +7%     
=======================================
  Files         108     108            
  Lines        8807    8491   -316     
=======================================
+ Hits         7284    7608   +324     
+ Misses       1523     883   -640     

@williamFalcon williamFalcon merged commit 5ec00cc into Lightning-AI:master Oct 1, 2020
@teddykoker teddykoker deleted the grad_clip_fp16_test branch October 1, 2020 14:02
@Borda Borda added this to the 0.10.0 milestone Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants