ref: move backends back to individual files (1/5) (ddp_cpu) #3712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamFalcon
changed the title
|
Hello @williamFalcon! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-09-29 05:41:49 UTC |
ananthsub
reviewed
Sep 29, 2020
|
|
||
| def get_device_ids(self): | ||
|
|
||
| class DDPCPUSpawnBackend(Accelerator): |
There was a problem hiding this comment.
naming nit: if run with torchelastic, then torchelastic does the spawn, not the backend. also this doesn't resolve the bug here: https://github.com/PyTorchLightning/pytorch-lightning/blob/master/pytorch_lightning/accelerators/accelerator_connector.py#L142-L143
we basically need a DDPCPUBackend which takes torchelastic_ddp as a mode
Codecov Report
@@ Coverage Diff @@
## master #3712 +/- ##
======================================
- Coverage 91% 90% -1%
======================================
Files 110 110
Lines 8206 8303 +97
======================================
+ Hits 7463 7507 +44
- Misses 743 796 +53 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
too complicated to understand and debug the merged backends.
cc @ananthsub
Also freebie @edenafek, raises exception when no valid backend is passed in