Mocking loggers (part 2, neptune) #3617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3617 +/- ##
=======================================
+ Coverage 83% 91% +7%
=======================================
Files 115 109 -6
Lines 8924 8080 -844
=======================================
- Hits 7425 7318 -107
+ Misses 1499 762 -737 |
|
@awaelchli is this ready? :] |
awaelchli
force-pushed
the
tests/mock-neptune
branch
from
10f7c0d to
425f33b
Compare
awaelchli
commented
Oct 5, 2020
| @@ -1,7 +1,6 @@ | |||
| # extended list of package dependencies to reach full functionality | |||
|
|
|||
| # TODO: this shall be removed as we mock them in tests | |||
| neptune-client>=0.4.109 | |||
There was a problem hiding this comment.
neptune install removed here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comes after #3596
When mocking neptune, I found that it actually does not support multi gpu currently.
This should get fixed in #3256 to avoid creating experiments when calling
logger.nameorlogger.version