Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error for cometml logger #3419

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Conversation

Vozf
Copy link
Contributor

@Vozf Vozf commented Sep 9, 2020

What does this PR do?

Fixes #3417

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team September 9, 2020 12:39
@Vozf Vozf changed the title Fix #3417 Fix error for cometml logger Sep 9, 2020
@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #3419 into master will increase coverage by 0%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #3419    +/-   ##
=======================================
  Coverage      90%     91%            
=======================================
  Files          98     101     +3     
  Lines        8073    8553   +480     
=======================================
+ Hits         7283    7747   +464     
- Misses        790     806    +16     

@williamFalcon williamFalcon merged commit 5b4db52 into Lightning-AI:master Sep 9, 2020
@Borda Borda added the bug Something isn't working label Sep 9, 2020
@Borda Borda added this to the 0.9.x milestone Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CometLogger failing without save_dir
3 participants