Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check for apex AMP and unit tests for Horovod + AMP #3404

Merged
merged 3 commits into from
Sep 9, 2020

Conversation

tgaddair
Copy link
Contributor

@tgaddair tgaddair commented Sep 8, 2020

What does this PR do?

Fixes #3111.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team September 8, 2020 21:35
@Borda Borda added the feature Is an improvement or enhancement label Sep 8, 2020
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot requested a review from a team September 8, 2020 22:50
@tgaddair
Copy link
Contributor Author

tgaddair commented Sep 9, 2020

Looks like test failures are unrelated:

tests/core/test_results.py::test_result_obj_predictions_ddp_spawn

@williamFalcon williamFalcon merged commit 091d37f into Lightning-AI:master Sep 9, 2020
@tgaddair tgaddair deleted the hvd-amp-fix branch September 9, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horovod with native 16 precision not working
3 participants