Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: inner train loop (intermediate step) 12/n #3372

Merged
merged 6 commits into from
Sep 6, 2020
Merged

Conversation

williamFalcon
Copy link
Contributor

@williamFalcon williamFalcon commented Sep 6, 2020

Moves train() to trainer.py from mixin

@mergify mergify bot requested a review from a team September 6, 2020 17:44
@codecov
Copy link

codecov bot commented Sep 6, 2020

Codecov Report

Merging #3372 into master will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #3372   +/-   ##
======================================
- Coverage      90%     90%   -0%     
======================================
  Files          93      93           
  Lines        8248    8183   -65     
======================================
- Hits         7449    7384   -65     
  Misses        799     799           

@williamFalcon williamFalcon merged commit 9939f53 into master Sep 6, 2020
@Borda Borda deleted the refa12 branch September 7, 2020 08:18
@Borda Borda added this to the 0.9.x milestone Sep 9, 2020
@Borda Borda added the refactor label Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants