-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics] Class reduction similar to sklearn #3322
[Metrics] Class reduction similar to sklearn #3322
Conversation
Hello @SkafteNicki! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-09-15 09:45:22 UTC |
This pull request is now in conflict... :( |
Codecov Report
@@ Coverage Diff @@
## master #3322 +/- ##
======================================
Coverage 90% 90%
======================================
Files 107 107
Lines 8149 8082 -67
======================================
- Hits 7332 7307 -25
+ Misses 817 775 -42 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…icki/pytorch-lightning into metrics/new_class_reduce
This pull request is now in conflict... :( |
just extended the timeout, but not the tests are running super long, about month or two ago we hand testing in 8min, now 30 is not enough... :/ |
This pull request is now in conflict... :( |
What does this PR do?
Fixes #3035
Changes the reduction for accuracy, precision, recall, fbeta, f1 metrics to be similar to sklearn: default will be 'micro' (global measure) with the option of 'macro' (our old standard, unweighted mean of individual scores), 'weighted' (weigted mean of individual scores) and 'none' (return score for each class).
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃