Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (weights only) checkpoints loading without pl #3287

Merged
merged 2 commits into from
Sep 2, 2020
Merged

Fix (weights only) checkpoints loading without pl #3287

merged 2 commits into from
Sep 2, 2020

Conversation

s-rog
Copy link
Contributor

@s-rog s-rog commented Aug 31, 2020

What does this PR do?

Fixes #2653

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team August 31, 2020 13:07
@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #3287 into master will decrease coverage by 6%.
The diff coverage is 50%.

@@           Coverage Diff           @@
##           master   #3287    +/-   ##
=======================================
- Coverage      90%     84%    -6%     
=======================================
  Files          86      88     +2     
  Lines        8102    9079   +977     
=======================================
+ Hits         7310    7608   +298     
- Misses        792    1471   +679     

@mergify mergify bot requested a review from a team September 1, 2020 07:03
@s-rog s-rog requested review from justusschock and Borda and removed request for a team September 2, 2020 00:16
@mergify mergify bot requested a review from a team September 2, 2020 00:16
Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot requested a review from a team September 2, 2020 07:43
@mergify mergify bot requested a review from a team September 2, 2020 08:20
@SkafteNicki SkafteNicki added the ready PRs ready to be merged label Sep 2, 2020
@Borda Borda added the bug Something isn't working label Sep 2, 2020
@Borda Borda merged commit 65e6687 into Lightning-AI:master Sep 2, 2020
@s-rog s-rog deleted the patch-2 branch September 2, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkpoints cannot be loaded in non-pl env
5 participants