-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix/3185 transpose #3252
bugfix/3185 transpose #3252
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3252 +/- ##
======================================
- Coverage 90% 90% -0%
======================================
Files 86 86
Lines 8095 8155 +60
======================================
+ Hits 7305 7319 +14
- Misses 790 836 +46 |
@lezwon mind adding a test so this doesn’t happen again? The test is to use some of the step result tests with TPUs which you can copy over into the TPU section |
@williamFalcon I had to make a couple of tweaks to get the tests working. They aren't related to this issue but might have been bugs needed to be fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐰
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What does this PR do?
Fixes #3185
Fixes #2903
tensor.t()
breaks on XLA for 1-D tensors. Replaced it withtensor.transpose(-1, 0)
.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃