Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/3185 transpose #3252

Merged
merged 9 commits into from
Sep 1, 2020

Conversation

lezwon
Copy link
Contributor

@lezwon lezwon commented Aug 29, 2020

What does this PR do?

Fixes #3185
Fixes #2903

tensor.t() breaks on XLA for 1-D tensors. Replaced it with tensor.transpose(-1, 0).

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team August 29, 2020 07:18
@codecov
Copy link

codecov bot commented Aug 29, 2020

Codecov Report

Merging #3252 into master will decrease coverage by 0%.
The diff coverage is 75%.

@@          Coverage Diff           @@
##           master   #3252   +/-   ##
======================================
- Coverage      90%     90%   -0%     
======================================
  Files          86      86           
  Lines        8095    8155   +60     
======================================
+ Hits         7305    7319   +14     
- Misses        790     836   +46     

@williamFalcon
Copy link
Contributor

@lezwon mind adding a test so this doesn’t happen again?

The test is to use some of the step result tests with TPUs which you can copy over into the TPU section

@lezwon
Copy link
Contributor Author

lezwon commented Aug 29, 2020

@williamFalcon I had to make a couple of tweaks to get the tests working. They aren't related to this issue but might have been bugs needed to be fixed.

@mergify mergify bot requested a review from a team August 29, 2020 18:49
@Borda Borda added the bug Something isn't working label Aug 29, 2020
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐰

@mergify mergify bot requested a review from a team August 29, 2020 18:53
@mergify mergify bot requested a review from a team September 1, 2020 06:48
Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Value out of range (expected to be in range of [-1, 0], but got 1) Batchsize and learning rate scheduler
6 participants