Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: add eval loop object to streamline eval loop #3138

Merged
merged 6 commits into from
Aug 25, 2020
Merged

Conversation

williamFalcon
Copy link
Contributor

No description provided.

@pep8speaks
Copy link

pep8speaks commented Aug 25, 2020

Hello @williamFalcon! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-08-25 01:03:34 UTC

@mergify mergify bot requested a review from a team August 25, 2020 00:59
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #3138 into master will increase coverage by 0%.
The diff coverage is 99%.

@@          Coverage Diff           @@
##           master   #3138   +/-   ##
======================================
  Coverage      90%     90%           
======================================
  Files          83      84    +1     
  Lines        7915    7950   +35     
======================================
+ Hits         7105    7140   +35     
  Misses        810     810           

@williamFalcon williamFalcon merged commit 229b876 into master Aug 25, 2020
@Borda Borda added the refactor label Aug 25, 2020
@Borda Borda added this to the 0.9.x milestone Aug 25, 2020
@Borda Borda deleted the ref14 branch August 25, 2020 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants