Refactor 1: moved tpu xxx_step to backend #3118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamFalcon
changed the title
williamFalcon
changed the title
Borda
reviewed
Aug 24, 2020
| from pytorch_lightning.utilities.apply_func import move_data_to_device | ||
|
|
||
|
|
||
| class Accelerator(object): |
Codecov Report
@@ Coverage Diff @@
## master #3118 +/- ##
======================================
- Coverage 90% 90% -0%
======================================
Files 81 82 +1
Lines 7738 7763 +25
======================================
+ Hits 6979 6988 +9
- Misses 759 775 +16 |
|
why would you move it to Accelerator, it will be the same in each backend or how it would differ? |
|
yes. only way to make this more general. each backend handles its own hooks. then you can just call a backend directly |
Borda
reviewed
Aug 24, 2020
Comment on lines
+121
to
+137
| def training_step(self, batch, args): | ||
| batch = self.to_device(batch) | ||
| args[0] = batch | ||
| output = self.trainer.model.training_step(*args) | ||
| return output | ||
|
|
||
| def validation_step(self, batch, args): | ||
| batch = self.to_device(batch) | ||
| args[0] = batch | ||
| output = self.trainer.model.validation_step(*args) | ||
| return output | ||
|
|
||
| def test_step(self, batch, args): | ||
| batch = self.to_device(batch) | ||
| args[0] = batch | ||
| output = self.trainer.model.test_step(*args) | ||
| return output |
There was a problem hiding this comment.
then this shall be in abstract class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.