Fix false num_classes warning in metrics #2781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @pwwang! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-07-31 22:05:11 UTC |
pwwang
changed the title
Put to_categorical before get_num_classes in metrics/functional/classification.py
Remove whitespaces in blank line.
|
Can you fix failing CIs? |
@pwwang mind rebase on master, these issues have been fixed today on master :] |
Borda
approved these changes
Jul 31, 2020
ananyahjha93
approved these changes
Jul 31, 2020
Codecov Report
@@ Coverage Diff @@
## master #2781 +/- ##
=======================================
- Coverage 91% 86% -4%
=======================================
Files 76 76
Lines 6787 6787
=======================================
- Hits 6150 5863 -287
- Misses 637 924 +287 |
this is strange, it speaks the stats even the condition of waiting for all 22 builds is not fulfill, just checked codecov and it has only 18 builds and still, it speaks... |
Diuven
pushed a commit
to Diuven/pytorch-lightning
that referenced
this pull request
Aug 3, 2020
Borda
added a commit
that referenced
this pull request
Aug 6, 2020
* Faster classfication stats * Faster accuracy metric * minor change on cls metric * Add out-of-bound class clamping * Add more tests and minor fixes * Resolve code style warning * Update for #2781 * hotfix * Update pytorch_lightning/metrics/functional/classification.py Co-authored-by: Jirka Borovec <[email protected]> * Update about conversation * Add docstring on stat_scores_multiple_classes Co-authored-by: Younghun Roh <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
williamFalcon
pushed a commit
that referenced
this pull request
Aug 8, 2020
* Faster classfication stats * Faster accuracy metric * minor change on cls metric * Add out-of-bound class clamping * Add more tests and minor fixes * Resolve code style warning * Update for #2781 * hotfix * Update pytorch_lightning/metrics/functional/classification.py Co-authored-by: Jirka Borovec <[email protected]> * Update about conversation * Add docstring on stat_scores_multiple_classes * Fixing #2862 Co-authored-by: Younghun Roh <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Put to_categorical before get_num_classes in metrics/functional/classification.py, which fixes false warning about num_classes.
Fixes #2768
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃