Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes train outputs #2428

Merged
merged 2 commits into from
Jun 30, 2020
Merged

Fixes train outputs #2428

merged 2 commits into from
Jun 30, 2020

Conversation

williamFalcon
Copy link
Contributor

@williamFalcon williamFalcon commented Jun 30, 2020 •
edited
Loading

Fixes #2372

Tests to ensure that

  • training_step outputs flow to training_step_end and training_epoch_end
  • tests all 4 combinations (train_step only), (train_step + train_step_end), (train_step + train_step_end + train_epoch_end) + (train_step + train_epoch_end)
  • asserts that grads are not retained beyond the training_step.

@mergify mergify bot requested a review from a team June 30, 2020 13:23
@williamFalcon williamFalcon mentioned this pull request Jun 30, 2020
Closed
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #2428 into master will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #2428   +/-   ##
======================================
  Coverage      89%     89%           
======================================
  Files          69      69           
  Lines        5476    5477    +1     
======================================
+ Hits         4856    4857    +1     
  Misses        620     620

Borda
Borda reviewed Jun 30, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just quick screening looks fine...

@mergify mergify bot requested a review from a team June 30, 2020 14:02
@williamFalcon williamFalcon merged commit a42a0e1 into master Jun 30, 2020
@Borda Borda deleted the outputs branch June 30, 2020 15:27
@Borda Borda added the bug Something isn't working label Jun 30, 2020
@Borda Borda added this to the 0.8.x milestone Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda left review comments

@awaelchli awaelchli Awaiting requested review from awaelchli

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
pl:0.8.x
Development

Successfully merging this pull request may close these issues.

training_epoch_end's outputs doesn't have 'loss' key
2 participants
@williamFalcon @Borda